A few fixes#49
Open
chscorpio wants to merge 3 commits into
Open
Conversation
Merge latest fixes from uudashr/jsmpp:master
|
Hi. This project has been moved to https://github.com/opentelecoms-org/jsmpp Best Regards, |
Author
|
Thanks for the link. My problems were corrected in master but not yet released to the maven repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a bug in the RelativeTimeFormatter. Basically, Calendar defaults to using my local TimeZone which breaks when setting the time using the calculated relativeTime from a Calendar in a possibly different TimeZone. Along the same lines, the format date unit tests were failing because the offset was still relative to my time zone. Instead, explicitly constructing the Calendar with the German time zone. Also, setting Calendar HOUR to 1 without AM_PM is left to interpretation and wasn't working for me. Instead, explicitly setting HOUR_OF_DAY to 13 is consistently working.
Finally, while integrating with an SMPP service, the OptionalParameters for-each loop was throwing a NullPointerException likely because they didn't send any OptionalParameters. Instead, I just check for null before executing the for-each loop.